Feature Requests

The MuWire file sharing application
Post Reply
zlatinb

Re: Feature Requests

Post by zlatinb »

B0B wrote: 23 Mar 2020 21:07
zlatinb wrote: 23 Mar 2020 20:47 And later is build 122. As with the table the tree will refresh up to 3 seconds after the file has been deleted, and should preserve the expanded state.
Up and running. It does a one-time refresh right after the tree is loaded? Should do the job. Great work.
Not quite, every 3 seconds the servlet is checked for updates to the library and if there are any the expanded tree nodes are refreshed. Source is here http://git.idk.i2p/zlatinb/muwire/blob/ ... s/files.js
User avatar
B0B
Posts: 51
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 24 Mar 2020 11:52 every 3 seconds the servlet is checked for updates to the library and if there are any the expanded tree nodes are refreshed. Source is here http://git.idk.i2p/zlatinb/muwire/blob/ ... s/files.js
Too bad I don't know anything about java-script but what I mean is that it looks like the screen does a refresh right after it's loaded. Not an annoyance or bug or something like that, just a thing that looks different when compared with earlier builds. It seems to work so I'm happy :-)

Last night my node went offline for some reason. MuWire and I2P service were running, just not connected. Had to manually stop and start the I2P service to get it going again. Log still shows critical errors which probably explain why my memory usage is higher than usual. This may or may have nothing to do with MuWire. Need to investigate.

Code: Select all

2020/03/24 12:19:46 | CRIT  [2CP Reader 6] 2p.router.client.ClientManager: Client attempted to register duplicate destination i4fptbsris(NUMBERS-HERE)o3htxc4o2liovxjq.b32.i2p
2020/03/24 12:20:44 | CRIT  [CP Reader 15] 2p.router.client.ClientManager: Client attempted to register duplicate destination i4fptbsr(NUMBERS-HERE)sao3htxc4o2liovxjq.b32.i2p
2020/03/24 12:21:13 | CRIT  [CP Reader 18] 2p.router.client.ClientManager: Client attempted to register duplicate destination 7e3q(NUMBERS-HERE)ngv4ietet72joygxv7h6pa.b32.i2p
2020/03/24 12:21:13 | CRIT  [CP Reader 19] 2p.router.client.ClientManager: Client attempted to register duplicate destination 4hb2hv6(NUMBERS-HERE)xva2xiaz5shk7atq.b32.i2p

edit:
And some more log-info...

Code: Select all

24 Mar 2020, 08:46:16 ERROR [2CP Reader 6] .client.ClientConnectionRunner: Disconnecting the client - java.io.EOFException: EOF reading 4 byte value
24 Mar 2020, 08:46:16 ERROR [l Reader 225] lient.impl.I2PSessionMuxedImpl: [MuWire #11558(OPEN)]: Error occurred communicating with router: Router shutdown
net.i2p.client.I2PSessionException: Disconnect Message received: Router shutdown
	at net.i2p.client.impl.DisconnectMessageHandler.handleMessage(DisconnectMessageHandler.java:33)
	at net.i2p.client.impl.I2PSessionImpl.messageReceived(I2PSessionImpl.java:1071)
	at net.i2p.internal.QueuedI2CPMessageReader$QueuedI2CPMessageReaderRunner.run2(QueuedI2CPMessageReader.java:56)
	at net.i2p.data.i2cp.I2CPMessageReader$I2CPMessageReaderRunner.run(I2CPMessageReader.java:164)
	at java.base/java.lang.Thread.run(Thread.java:830)
	at net.i2p.util.I2PThread.run(I2PThread.java:103)
24 Mar 2020, 08:46:16 ERROR [l Reader 225] ire.core.hostcache.CacheClient: I2P error occured Router shutdown net.i2p.client.I2PSessionException: Disconnect Message received: Router shutdown
Last edited by B0B on 24 Mar 2020 12:56, edited 1 time in total.
zlatinb

Re: Feature Requests

Post by zlatinb »

B0B wrote: 24 Mar 2020 12:46 Last night my node went offline for some reason. MuWire and I2P service were running, just not connected. Had to manually stop and start the I2P service to get it going again. Log still shows critical errors which probably explain why my memory usage is higher than usual. This may or may have nothing to do with MuWire. Need to investigate.

Code: Select all

2020/03/24 12:19:46 | CRIT  [2CP Reader 6] 2p.router.client.ClientManager: Client attempted to register duplicate destination i4fptbsris(NUMBERS-HERE)o3htxc4o2liovxjq.b32.i2p
2020/03/24 12:20:44 | CRIT  [CP Reader 15] 2p.router.client.ClientManager: Client attempted to register duplicate destination i4fptbsr(NUMBERS-HERE)sao3htxc4o2liovxjq.b32.i2p
2020/03/24 12:21:13 | CRIT  [CP Reader 18] 2p.router.client.ClientManager: Client attempted to register duplicate destination 7e3q(NUMBERS-HERE)ngv4ietet72joygxv7h6pa.b32.i2p
2020/03/24 12:21:13 | CRIT  [CP Reader 19] 2p.router.client.ClientManager: Client attempted to register duplicate destination 4hb2hv6(NUMBERS-HERE)xva2xiaz5shk7atq.b32.i2p
This isn't good, we should try to get to the bottom of what's going on. These duplicate destinations could be symptoms of a router bug.

Can you create a post in the router forum and provide these logs, as well as some general info about your router, esp. what plugins or client apps you use?
zlatinb

Re: Feature Requests

Post by zlatinb »

B0B wrote: 24 Mar 2020 12:46 t looks like the screen does a refresh right after it's loaded.
I see it now, shouldn't be hard to fix
User avatar
B0B
Posts: 51
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 24 Mar 2020 12:55 Can you create a post in the router forum and provide these logs, as well as some general info about your router, esp. what plugins or client apps you use?
Well, I run the I2Speed update, which is not the official "zzz" package. That may not be the right place to report issues. Maybe I should just downdate (is that a word?) to the official 0.9.45-0 first, just to be sure.

zlatinb wrote: 24 Mar 2020 12:57 I see it now, shouldn't be hard to fix
So, it was not as intended? Works anyways :-)
zlatinb

Re: Feature Requests

Post by zlatinb »

B0B wrote: 24 Mar 2020 13:03
zlatinb wrote: 24 Mar 2020 12:57 I see it now, shouldn't be hard to fix
So, it was not as intended? Works anyways :-)
Fixed in build 126
zlatinb

Re: Feature Requests

Post by zlatinb »

zlatinb wrote: 23 Mar 2020 18:34 This is a proper bug, thanks for finding it! Fixed in b113.
And build 127 fixes the case where an entire directory is deleted. This is big enough to prompt a 0.6.12 release as the bug affects the standalone version as well.
User avatar
B0B
Posts: 51
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 25 Mar 2020 08:15 And build 127 fixes the case where an entire directory is deleted.
That's something I didn't test. Good to know it won't cause issues in the future.

Latest error-update:
Last night my system rebooted without leaving an error-message in the Win log. A bit later I did the b127 update and to my surprise MuWire auto started without a hitch. At checking the I2P logs I noticed the "duplicate" errors weren't there anymore. Really weird.
User avatar
B0B
Posts: 51
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

May I suggest a small cosmetic CSS adjustment for the Shared files Tree & Table?

Changing background and adding hover color to improve visibility.
Different padding to center content in drop box.

Code: Select all

.dropdown-content
{
background: #c8e0ff;
background-color: #c8e0ff;
padding: 3px 14px 3px 14px;
}

Code: Select all

.dropdown-content a:hover
{
background: #d8f0ff;
background-color: #d8f0ff;
}
Of course, the used colors are just examples and can be adjusted at will. Changes are tiny so no need for a new build for just this.
zlatinb

Re: Feature Requests

Post by zlatinb »

B0B wrote: 25 Mar 2020 15:11 May I suggest a small cosmetic CSS adjustment for the Shared files Tree & Table?

Changing background and adding hover color to improve visibility.
Different padding to center content in drop box.
Of course, the used colors are just examples and can be adjusted at will. Changes are tiny so no need for a new build for just this.
Thanks, pushed to git and build b1 is now available for download. New builds are cheap because I have to increment the build number every time I test something, otherwise the router will not let me update the plugin. When I'm done testing I just put the latest build on http://muwire.i2p

I've credited you in the commit log, but I would really like it if you registered at http://git.idk.i2p and opened PRs in future. That way of work is much more sustainable than patches on forums :)
Post Reply