Feature Requests

The MuWire file sharing application
User avatar
zlatinb
Posts: 103
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

Using X:\MyDownloads returns an error (refuses to save settings)
What is the exact error message you're getting? There are 3 possible error messages;
1) X does not exist
2) X is not a directory
3) X is not writeable

Also, please try restarting the plugin and i2p router after mapping the network drive. I really don't know how things work in windows, but it's possible the mapped drive becomes visible only to newly launched processes. If that's the case, you will need to restart the entire i2p router.
"Browse" returns this error after a string is entered
I should make the error more descriptive. In the Browse input box MuWire expects you to enter the full id of the user you want to browse. Users of the desktop version can get their full id by clicking on the "Copy Full" button on the main window. (Brief description of short vs. full nicknames here https://github.com/zlatinb/muwire/wiki/Nicknames ). I should probably add a way to copy the full user id from the plugin as well.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: https://muwire.com
MuCats: http://mucats.i2p
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 19 Mar 2020 14:45 What is the exact error message you're getting?
Just a non-exist message. It doesn't "see" the X: device

Bad input:X:\MyNAS4\MyDownloads does not exist
zlatinb wrote: 19 Mar 2020 14:45 Also, please try restarting the plugin and i2p router after mapping the network drive.
The X: drive is mapped at start-up. I2P start-up is delayed. I even have a BATch-file that checks if X: is accessible before I2P will be started.
Note that it does work when directly editing MuWire.properties. It shows up in the settings the right way but the settings just can't be saved anymore (MuWire doesn't recognize the syntax?)
zlatinb wrote: 19 Mar 2020 14:45 I should make the error more descriptive. In the Browse input box MuWire expects you to enter the full id of the user
That would be nice.


Bob
User avatar
zlatinb
Posts: 103
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

I couldn't reproduce this on my Windows 10 VM. Just in case, I've made a small change in build 34 which is now available at http://muwire.i2p . Please update and let me know if it works or if it displays a different error message.

The change is to resolve any shortcuts / symlinks when testing if the download location is accessible.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: https://muwire.com
MuCats: http://mucats.i2p
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 19 Mar 2020 16:20 I've made a small change in build 34 which is now available at http://muwire.i2p . Please update and let me know if it works or if it displays a different error message.
Updated to build 40. No change in mapped drive behavior. Same error.

Noticed the new "About Me" button. Small cosmetic issue: full MuWire id is a really long string so you need a real big screen / high resolution to make it fit in a browser window. Maybe using a text-form-box (what's-it-called) is an idea? With a "copy" button (to clipboard) the long string can have line feeds (visibly) without malforming the data.


Bob

edit: For some reason the "Share downloaded files" box was unchecked after the update. Had to re-enable it.
User avatar
zlatinb
Posts: 103
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

B0B wrote: 19 Mar 2020 18:56
Updated to build 40. No change in mapped drive behavior. Same error.
I really don't now where to go from here,
B0B wrote: 19 Mar 2020 18:56
Noticed the new "About Me" button. Small cosmetic issue: full MuWire id is a really long string so you need a real big screen / high resolution to make it fit in a browser window. Maybe using a text-form-box (what's-it-called) is an idea? With a "copy" button (to clipboard) the long string can have line feeds (visibly) without malforming the data.
In build 42 I switched to a <textarea> tag and added a Copy-To-Clipboard link. I tested it on Firefox, should work on other browsers too.

B0B wrote: 19 Mar 2020 18:56 edit: For some reason the "Share downloaded files" box was unchecked after the update. Had to re-enable it.
This is a bug - if any of the settings fail to be apply, all checkboxes revert to their default values. Thanks for pointing it out, will try to come up with a fix soon.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: https://muwire.com
MuCats: http://mucats.i2p
User avatar
zlatinb
Posts: 103
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

zlatinb wrote: 19 Mar 2020 19:28 This is a bug - if any of the settings fail to be apply, all checkboxes revert to their default values. Thanks for pointing it out, will try to come up with a fix soon.
Fixed in build 44.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: https://muwire.com
MuCats: http://mucats.i2p
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 19 Mar 2020 20:22 Fixed in build 44.
You are fast! :-)

Running the 44 build now. The text-area box looks exactly how I had it in mind. Fully functional and implemented very nice.

Of course, no change in the mapped drive settings.
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

Now that I'm at it, some cosmetic suggestions, albeit that some are personal preferences.

- Shared files list, Tree view
It gets messy when in a small browser window. The X-pos of the folder names is fixed. To make more room for the file names it would help if the folder name position was dynamic. Right now the next folder name will be placed where the previous ended. If the position was like 10% from left margin, 20% from left margin, etc, the tree will be less wide on smaller screens while still looking like a tree.

- Shared files list, Tree and Table view
Using small buttons for the Unshare Comment Certify Publish options in stead of the full text also saves some space.

- Buttons
You can get rid of the MuWire button (/MuStatus) in the left pane if you make the Connections: button clickable.

(all based when rendered with Firefox 68.6.0esr)


Bob
User avatar
zlatinb
Posts: 103
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

Thanks a lot for these suggestions! Comments on each item below:
B0B wrote: 20 Mar 2020 13:03 - Shared files list, Tree view
I'm totally hopeless with CSS but I'll pass your suggestion onto zzz who did the CSS for me. Unless you want to contribute a patch? Note if you want to contribute that I'm trying to re-license MW under Public Domain so that it can be bundled by default with the java I2P router.
B0B wrote: 20 Mar 2020 13:03 - Shared files list, Tree and Table view
Using small buttons for the Unshare Comment Certify Publish options in stead of the full text also saves some space.
I was actually thinking of using an ellipsis that opens a drop-down menu, but I haven't figured out exactly how to code it yet. Icons are also difficult for me as I'm equally hopeless with graphical stuff. If that problem gets solved somehow I would like to replace all icons anyway as the current ones are licensed under GPLv3 (since they're taken from Bote).
B0B wrote: 20 Mar 2020 13:03 - Buttons
You can get rid of the MuWire button (/MuStatus) in the left pane if you make the Connections: button clickable.
That is clever and pretty easy to do, although I'd probably keep the link to /MuWire. What I want to do and haven't figured out how yet is to make the sidebar menu sections collapsible with "Trust" and "About" collapsed by default for example.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: https://muwire.com
MuCats: http://mucats.i2p
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote: 20 Mar 2020 13:24 I'm totally hopeless with CSS but I'll pass your suggestion onto zzz who did the CSS for me. Unless you want to contribute a patch?
I know a bit of HTML, PHP and CSS but unfortunately not enough to create something useful.
zlatinb wrote: 20 Mar 2020 13:24 I was actually thinking of using an ellipsis that opens a drop-down menu, but I haven't figured out exactly how to code it yet.
Sound like an idea that's even better.
zlatinb wrote: 20 Mar 2020 13:24 Icons are also difficult for me as I'm equally hopeless with graphical stuff. If that problem gets solved somehow I would like to replace all icons anyway as the current ones are licensed under GPLv3 (since they're taken from Bote).
Making icons is no problem for me but it's a matter of taste if one likes them or not. I'll try to find some time to make a few.
zlatinb wrote: 20 Mar 2020 13:24 That is clever and pretty easy to do, although I'd probably keep the link to /MuWire. What I want to do and haven't figured out how yet is to make the sidebar menu sections collapsible with "Trust" and "About" collapsed by default for example.
There are a multitude of options when and where to expand/collapse which menu and why. It also depends on possible features that may be added later on. Definitely not an easy task to find "the" layout that fits everyone.
Post Reply