Feature Requests

The MuWire file sharing application
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote:
25 Mar 2020 22:47
What you want to do is "Fork" the repo, then "Clone" from your fork (which will appear under your namespace). Then commit the new icon to your fork, (in "webui/src/main/images/" then create a merge request back to my repo.
I have no idea how but somehow it worked. Clicked on everything that crossed my sight. But it's terribly slooooow. Switching pages takes ages on my system.
User avatar
zlatinb
Posts: 94
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

B0B wrote:
25 Mar 2020 23:48
zlatinb wrote:
25 Mar 2020 22:47
What you want to do is "Fork" the repo, then "Clone" from your fork (which will appear under your namespace). Then commit the new icon to your fork, (in "webui/src/main/images/" then create a merge request back to my repo.
I have no idea how but somehow it worked. Clicked on everything that crossed my sight. But it's terribly slooooow. Switching pages takes ages on my system.
Congratulations, you're now officially on the timeline here http://git.idk.i2p/zlatinb/muwire/commits/master
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: http://muwire.com
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote:
25 Mar 2020 23:53
Congratulations, you're now officially on the timeline here http://git.idk.i2p/zlatinb/muwire/commits/master
It's an honor , I think? :lol:

Glad to be of any help. Have no clue about java so I can't mean a thing with that.
User avatar
zlatinb
Posts: 94
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

zlatinb wrote:
25 Mar 2020 21:18
I'm going to make every watched directory configurable separately from the others. There will also be a default value.

I will need an icon for an "Advanced Sharing" page in the "Configuration" section on the sidebar. On that page there will be a table with all watched directories and ability to configure refresh interval (and other settings that may come up in the future) for each watched directory.
Above is more or less done in 0.6.12-b14. In the "Advanced Sharing" page you need to turn off "Auto Watch" then you can do manual syncs periodically or on demand.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: http://muwire.com
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote:
27 Mar 2020 16:00
Above is more or less done in 0.6.12-b14. In the "Advanced Sharing" page you need to turn off "Auto Watch" then you can do manual syncs periodically or on demand.
You mean, on Windows systems "Auto Watch" doesn't work (yet?) so you always need to enable the timed sync option?

Updated, but will test tomorrow (it's 3:30AM right now :-) )
User avatar
zlatinb
Posts: 94
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

B0B wrote:
28 Mar 2020 02:29
zlatinb wrote:
27 Mar 2020 16:00
Above is more or less done in 0.6.12-b14. In the "Advanced Sharing" page you need to turn off "Auto Watch" then you can do manual syncs periodically or on demand.
You mean, on Windows systems "Auto Watch" doesn't work (yet?) so you always need to enable the timed sync option?

Updated, but will test tomorrow (it's 3:30AM right now :-) )
On NAS devices no, it won't work. I think auto-watch won't work on NAS regardles of the OS.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: http://muwire.com
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote:
28 Mar 2020 03:07
On NAS devices no, it won't work. I think auto-watch won't work on NAS regardles of the OS.
If it really is java not "polling", then yes. "NAS" in this case just means any kind of network path (on Windows, that is). Be it your phone or another computer.

Maybe it's possible to detect the host o.s. If it's Windows, the "auto-watch" default is "not checked", or not even available at all. Or even better, check for polling ability regardless the used o.s. No idea what an be done and what not.

For now it seems to work very well.. If it stays like this a kind of "warning" may be necessary for those win-users, to let them know they need to disable auto-watch.

b.t.w: what about the "incompleted" downloads folder? Does MuWire also share the incomplete data from running downloads or is the data only used for internal use? This, because if it's able to upload incomplete data it also must be "watched", I guess.
User avatar
zlatinb
Posts: 94
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

B0B wrote:
28 Mar 2020 14:40

Maybe it's possible to detect the host o.s. If it's Windows, the "auto-watch" default is "not checked", or not even available at all. Or even better, check for polling ability regardless the used o.s. No idea what an be done and what not.
Detecting the OS is easy, but why disable auto-watch it when it works fine on local hard drives? Auto-watch is identical to that small java program you tested on your D:\test folder and it worked.
B0B wrote:
28 Mar 2020 14:40
For now it seems to work very well.. If it stays like this a kind of "warning" may be necessary for those win-users, to let them know they need to disable auto-watch.
Glad to hear. I've added a short description to the /AdvancedSharing page to let users know that for NAS devices they may need to turn off auto-watch.
B0B wrote:
28 Mar 2020 14:40
b.t.w: what about the "incompleted" downloads folder? Does MuWire also share the incomplete data from running downloads or is the data only used for internal use? This, because if it's able to upload incomplete data it also must be "watched", I guess.
MuWire does share data from incomplete downloads, but only from it's own downloads. What I mean by that is if you share the MuWire incompletes folder with another program, that program's partial downloads will not get shared via MW. So it is not necessary to "watch" the incompletes folder as MW has other ways of tracking what parts of the file can be uploaded.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: http://muwire.com
User avatar
B0B
Posts: 46
Joined: 18 Mar 2020 11:48
Location: NL

Re: Feature Requests

Post by B0B »

zlatinb wrote:
28 Mar 2020 14:57
Detecting the OS is easy, but why disable auto-watch it when it works fine on local hard drives? Auto-watch is identical to that small java program you tested on your D:\test folder and it worked.
Yes, confused wording from me and I was just editing it while you posted this reply.

What I actually meant was: set the "auto-watch" default to "disabled" for any network path. So, if a shared path looks like "\\NAS\MyShares", Timed Directory Sync will be enabled with a default value, like 40 or 120 seconds or whatever. This is just to make it more easy for the average user. It won't change functionality but makes it work "out-of-the-box". Timing adjustments can me made afterwards if one wants to.

An issue may be the network path detection. On Windows, paths starting with "\\" are network paths but I don't know if it's the same on other o.s'. A problem will be mapped network paths. Those start with a device id (like "X:") so from that point of view they look like local storage but are in fact networked paths, so no polling by the o.s.

All above is only when you stick to "this" solution. If you've plans to radically change it later on it's not worth to spend too much time on it.
zlatinb wrote:
28 Mar 2020 14:57
So it is not necessary to "watch" the incompletes folder as MW has other ways of tracking what parts of the file can be uploaded.
That clarifies it. And yes, I'm only talking about data within MuWire itself.


p.s. The forum set-up sux when used with private browsing. Need to login again with every action I do only to be greeted with a "excessive requests" message, denying me to submit a new post for a while.
User avatar
zlatinb
Posts: 94
Joined: 24 May 2018 17:14

Re: Feature Requests

Post by zlatinb »

B0B wrote:
28 Mar 2020 15:29
An issue may be the network path detection. On Windows, paths starting with "\\" are network paths but I don't know if it's the same on other o.s'. A problem will be mapped network paths. Those start with a device id (like "X:") so from that point of view they look like local storage but are in fact networked paths, so no polling by the o.s.
Correct, detecting if a path is a network path is impossible from pure Java (to my knowledge at least). On Linux and probably Mac the mapped drives appear as regular iNodes.
B0B wrote:
28 Mar 2020 15:29
All above is only when you stick to "this" solution. If you've plans to radically change it later on it's not worth to spend too much time on it.
At the moment I don't really have any plans to change the approach. For now I've added "Help" tooltips next to the "Share" button that warn the user about networked drives situation in build b27.
GPG: https://keybase.io/zlatinb
blog: http://zab.i2p
mail: zab@mail.i2p
MuWire: http://muwire.com
Post Reply